Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Collections-Abstract-Traits (TSortable) #16533

Open
wants to merge 4 commits into
base: Pharo13
Choose a base branch
from

Conversation

pavel-krivanek
Copy link
Collaborator

fixes #16357

@jecisc
Copy link
Member

jecisc commented Apr 27, 2024

This is also referenced in the bootstrap script

@jecisc jecisc added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Apr 27, 2024
@pavel-krivanek
Copy link
Collaborator Author

Thank you! The next try

@jecisc jecisc closed this May 9, 2024
@jecisc jecisc reopened this May 9, 2024
@jecisc jecisc removed the Status: Need more work The issue is nearly ready. Waiting some last bits. label May 9, 2024
@jecisc
Copy link
Member

jecisc commented May 14, 2024

This PR still has some problems. Apparently we have tests relying on this trait. We should update them to use another trait (Maybe one specifically for the tests?)

For example: Found undeclared Variables: TSortable in: RGMetatraitDefinitionTest>>#testAsClassTraitfinition

@jecisc jecisc added the Status: Need more work The issue is nearly ready. Waiting some last bits. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSortable is not used
2 participants