Remove empty Manifests from baseline packages, synchronize on the tag… #16537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name #Baseline for Baseline methods where the Manifest is useful.
|
But those manifest are there for the false positive on the not reference rule no? |
|
yes, but in case of these removed ones, they are completely empty so there is no need to have them at all and there is no need for the baseline packages have more tags. Only in case the manifest is not empty, there will be two tags - Manifest and Baseline. |
|
But I see some content with the ban of the rule: |
|
yes, but in this case, it is an obsolete record ;-) |
jecisc
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… name #Baseline for Baseline methods where the Manifest is useful.
fixes #8016