Fix a small bug with FFI calls when passing 'NULL' as argument to the C function #16562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… C function to call. Now it can infer its type correctly as 'void*'
astares
reviewed
May 14, 2024
| There is no ambiguity. | ||
| " | ||
|
|
||
| (aFFIValueArgument value isNil |
There was a problem hiding this comment.
This give a lint issue and to make it easier it could be rewritten as
(#(nil 'nil' 'NULL') includes: aFFIValueArgument value)
ifTrue: [ ^ (aResolver resolveType: #'void *') ].
...avoiding the critique to appear
There was a problem hiding this comment.
Thanks @astares, I applied your suggestion using the github review tool.
Let's wait for the CI
|
Also this PR should be against Pharo13 branch (with a possible backport to P12) |
|
I changed the base of the PR, thanks for the catch @astares |
guillep
reviewed
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it can infer its type correctly as 'void*'