Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposition for a potential new rule: use deny: instead of assert:equals:false #16668

Merged
merged 3 commits into from
May 21, 2024

Conversation

AngelHely
Copy link
Contributor

This pull request propose a potential new rule with autofix to check method that use assert:equals: to verify that something is false and propose to use deny: #16574

@AngelHely AngelHely closed this May 17, 2024
@AngelHely AngelHely reopened this May 17, 2024
@jecisc
Copy link
Member

jecisc commented May 21, 2024

I think we should have more in this rule.

- #assert: instead of #assert:equals: true
- #assert: instead of #deny:equals: false
- # deny: instead of #deny:equals: true

And the 4 also for assert:/deny:identicalTo:

So we should have 8 cases covered by this rule

@jecisc jecisc merged commit 87be1fb into pharo-project:Pharo13 May 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants