add no-multi-assign-on-declaration lint rule, phetsims/chipper#794

phetsims · Nov 7, 2019 · 50613e8 · 50613e8
1 parent 34c4c0a
commit 50613e8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/js/PhetMenu.js b/js/PhetMenu.js
@@ -365,8 +365,7 @@ define( require => {
     const maxTextHeight = _.maxBy( textNodes, function( node ) {return node.height;} ).height;
 
     // Create the menu items.
-    const items = this.items = _.map( keepItemDescriptors, function( itemDescriptor ) {
-
+    const items = _.map( keepItemDescriptors, function( itemDescriptor ) {
         const menuItemOptions = {
           textFill: itemDescriptor.textFill,
           checkedProperty: itemDescriptor.checkedProperty,
@@ -397,6 +396,7 @@ define( require => {
         );
       }
     );
+    this.items = items;
 
     const separatorWidth = _.maxBy( items, function( item ) {return item.width;} ).width;
     const itemHeight = _.maxBy( items, function( item ) {return item.height;} ).height;