fix: if sim doesn't have translated file, set shared strings to empty

For #342. Part of phetsims/qa#869.
phetsims · Dec 21, 2022 · 85f046c · 85f046c
1 parent e7cee15
commit 85f046c
Showing 1 changed file with 19 additions and 3 deletions.
diff --git a/src/server/translationApi/getSharedTranslationFormData.js b/src/server/translationApi/getSharedTranslationFormData.js
@@ -41,9 +41,19 @@ const getSharedTranslationFormData = async (
       for ( const sim of sharedSims ) {
         const simFileRes = await axios.get( getStringFileUrl( sim ) );
         englishStringFiles.push( simFileRes.data );
-        const translatedFileRes = await axios.get( getTranslatedStringFile( sim, locale ) );
-        if ( translatedFileRes.status >= 200 && translatedFileRes.status <= 300 ) {
-          translatedStringFiles.push( translatedFileRes.data );
+        try {
+          const translatedFileRes = await axios.get( getTranslatedStringFile( sim, locale ) );
+          if ( translatedFileRes.status >= 200 && translatedFileRes.status <= 300 ) {
+            translatedStringFiles.push( translatedFileRes.data );
+          }
+        }
+        catch( e ) {
+          if ( e.response.status === 404 ) {
+            logger.verbose( `translation file for ${simName} doesn't exist; setting empty strings for ${simName}` );
+          }
+          else {
+            logger.error( e );
+          }
         }
       }
 
@@ -79,6 +89,12 @@ const getSharedTranslationFormData = async (
             translated: translatedKeysAndValues[ stringKey ]
           };
         }
+        else if ( englishKeysAndValues[ stringKey ] && !translatedKeysAndValues[ stringKey ] ) {
+          sharedTranslationFormData[ stringKeyWithoutDots ] = {
+            english: englishKeysAndValues[ stringKey ],
+            translated: ''
+          };
+        }
       }
     }
     catch( e ) {