Fix npm warnings #78
Merged
Fix npm warnings #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm is giving these warnings on every `npm install`: ``` npm WARN deprecated node-uuid@1.4.7: use uuid module instead npm WARN deprecated tough-cookie@2.2.2: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130 ``` These dependencies are installed by the package `request`, and upgrading that package should fix it.
|
Unfortunately there seems to be some differences related to timeouts in newer versions of request, breaking one of our tests. I'm also seen the same as visible in Travis CI run. Probably something fishy we're doing on our end in combination with request/request#2431. Will have to dig more into what's happening before fixing/merging this. |
|
After fixing the timeout test on master, Travis got happy. Thanks for pushing this update 👍 |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm is giving these warnings on every
npm install:These dependencies are installed by the package
request, and upgrading that package should fix it.