Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump suggested node_version due to npm bug #3801

Merged
merged 1 commit into from Apr 27, 2020

Conversation

petermm
Copy link
Contributor

@petermm petermm commented Apr 27, 2020

node 10.19.0 was bitten by this bug "invalid bin entry" - failing on npm install (sic!) npm/cli#613

see also https://elixirforum.com/t/cant-deploy-phoenix-app-to-heroku/31023

馃挋

does this need to be "backported" to 1.5 branch to appear on site?

node 10.19.0 was bitten by this bug "invalid bin entry" - failing on npm install (sic!) npm/cli#613

see also https://elixirforum.com/t/cant-deploy-phoenix-app-to-heroku/31023

馃挋

does this need to be "backported" to 1.5 branch to appear on site?
@Gazler Gazler merged commit 6648e23 into phoenixframework:master Apr 27, 2020
@Gazler
Copy link
Member

Gazler commented Apr 27, 2020

Thanks <3

This does need backported, I'll take care of that though.

Gazler pushed a commit that referenced this pull request Apr 27, 2020
node 10.19.0 was bitten by this bug "invalid bin entry" - failing on npm install (sic!) npm/cli#613

see also https://elixirforum.com/t/cant-deploy-phoenix-app-to-heroku/31023

馃挋

does this need to be "backported" to 1.5 branch to appear on site?
@petermm petermm deleted the patch-5 branch April 27, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants