Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade copy-webpack-plugin to version 6.0.3 #3961

Closed
wants to merge 1 commit into from
Closed

Upgrade copy-webpack-plugin to version 6.0.3 #3961

wants to merge 1 commit into from

Conversation

miquecg
Copy link

@miquecg miquecg commented Aug 12, 2020

copy-webpack-plugin version 5.1.1 is stucked with a vulnerable dependency: serialize-javascript@2.1.2. A major version upgrade is required.

This new version introduces several breaking changes:

the plugin now accepts an object, you should change new CopyPlugin(patterns, options) to new CopyPlugin({ patterns, options })

This major version upgrade is required to fix
a vulnerability in one of its dependencies:

serialize-javascript@2.1.2
@jeregrine
Copy link
Member

jeregrine commented Aug 14, 2020

I have confirmed this is a correct change. 👍 https://github.com/webpack-contrib/copy-webpack-plugin/blob/master/CHANGELOG.md#-breaking-changes appears we are not using any of the other features that got changed.

@Thomas-Sciaroni
Copy link

Anecdotally, I manually performed this change myself in my projects and it didn't break anything.

This is marked as a high severity vulnerability on npm https://www.npmjs.com/advisories/1548

@cw789
Copy link
Contributor

cw789 commented Nov 2, 2020

Will also land within #4054.

@miquecg
Copy link
Author

miquecg commented Nov 7, 2020

Superseded by #4054.

@miquecg miquecg closed this Nov 7, 2020
@miquecg miquecg deleted the copy-webpack-plugin-6.0.3 branch November 7, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants