New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Webpack 5 #4083

Closed

jamilabreu wants to merge 1 commit into phoenixframework:master from jamilabreu:webpack5

Contributor

jamilabreu commented Nov 27, 2020

Removed:

hard-source-webpack-plugin (now included in Webpack: Error when using with webpack 5 mzgoddard/hard-source-webpack-plugin#514 (comment)
terser-webpack-plugin (now included in Webpack: https://webpack.js.org/plugins/terser-webpack-plugin/)

Changed:

Move from deprecated optimize-css-assets-webpack-plugin ([question] will the 5.x version work with webpack 5? do we have plan to make this plugin work with webpack5? NMFR/optimize-css-assets-webpack-plugin#134 (comment)) to css-minimizer-webpack-plugin
Watcher command changes from '--watch-stdin' to '--watch'


          Upgrade to Webpack 5

f6d1a62

Contributor

cw789 commented Nov 27, 2020

Hey, have a look at my PR: #4054

Contributor

cw789 commented Nov 27, 2020

One thing still "problematic", watch mode doesn't work as expected for some people with "lot" of static files ...

Member

josevalim commented Dec 2, 2020

Closing as duplicate of #4054 for now!

josevalim closed this

Contributor

szTheory commented Dec 29, 2020

@jamilabreu Thanks I was able to upgrade to Webpack 5 and keep live reload with your suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment