update PageController index action to home in Controllers Guide #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhessler
changed the title
phoebe100
reviewed
Mar 17, 2023
phoebe100
reviewed
Mar 17, 2023
phoebe100
reviewed
Mar 17, 2023
|
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure how it was setup before Phoenix 1.7, but the default action for "/" is now
PageController.homeand notPageController.index. I've gone through and updated the controller guide docs changing appropriate references to thehomeaction and addinglayout: falsein the code snippets as well.In the flash section I removed the
infoflash message as it cannot be seen along with theerrorflash message and might cause confusion and updated the reference to theflashcode in the app template to point at theflash_groupcomponent added to the top of thehome.html.heexfile.resolves issue #5365