Allow mix ecto.setup from the umbrella root.
#5692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows running `mix ecto.setup` from the root of an umbrella project.
josevalim
reviewed
Jan 29, 2024
| @@ -52,7 +52,7 @@ defmodule <%= @app_module %>.MixProject do | |||
| defp aliases do | |||
| [ | |||
| setup: ["deps.get"<%= if @ecto do %>, "ecto.setup"<% end %>]<%= if @ecto do %>, | |||
| "ecto.setup": ["ecto.create", "ecto.migrate", "run priv/repo/seeds.exs"], | |||
| "ecto.setup": ["ecto.create", "ecto.migrate", "run #{__DIR__}/priv/repo/seeds.exs"], | |||
There was a problem hiding this comment.
If we need to add this entry, it means it is running on several apps. We probably need a different solution. Perhaps we should use an alias with Code.require_file?
There was a problem hiding this comment.
This is why I pushed this PR; regardless of how many apps I have with different databases, when I invoke mix ecto.setup in the root, I want all my apps to run it. If I cared about only a specific app, I would follow the current behaviour, which is to cd into my app and invoke mix ecto.setup.
With that in mind, I'm unsure what the issue is. Can you please provide some more context? Maybe I'm missing something obvious.
There was a problem hiding this comment.
I misunderstood. This looks good to me then. :)
josevalim
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows running
mix ecto.setupfrom the root of an umbrella project.