Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bandit to tests in /integration #5707

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtrudel
Copy link
Member

@mtrudel mtrudel commented Jan 30, 2024

Intended to follow #5706. Depends on Phoenix moving its minimum Elixir version to 1.12, since Bandit has hard test-dependencies thereon.

@mtrudel
Copy link
Member Author

mtrudel commented Jan 31, 2024

These tests run quite a bit slower than previously because we're starting / stopping the underlying server via a setup block instead of a setup_all (ie: we're doing it for each test). Cowboy seems to have a stock 5 second waiting period at the end of every test as a result (previously, it only waited once, at the end of the entire file).

We don't really need to be doing this this way, but fixing it properly will be a bit more surgery than what's here. I'll get it fixed up.

@mtrudel mtrudel marked this pull request as draft February 2, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant