Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist remote_ip during recycling of a conn #5792

Merged

Conversation

JonRowe
Copy link
Contributor

@JonRowe JonRowe commented Apr 22, 2024

Currently, if you set remote_ip during a test when building a conn, calling a dispatch call e.g get will run the conn through recycle which will lose this information. This PR changes that so it is maintained similar to host.

Co-authored-by: Nathan Long <him@nathanmlong.com>
@josevalim josevalim merged commit 1820877 into phoenixframework:main May 2, 2024
6 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@JonRowe JonRowe deleted the persist-remote-ip-during-recycle branch May 2, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants