This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Use camel case for element attribute and event names #282

Open

gnestor wants to merge 2 commits into phosphorjs:master from gnestor:camel-case

gnestor commented Jun 7, 2017 •

edited

Broken out from #281

This will allow phosphor’s virtualdom to support rendering React functional/stateless components.

To do:

Switch from no-case to camel-case for attribute and event names
Name parity with React
- React's list of attribute names: https://github.com/facebook/react/blob/b1768b5a48d1f82e4ef4150e0036c5f846d3758a/src/renderers/dom/shared/HTMLDOMPropertyConfig.js#L28-L207
- Phosphor's list of attribute names: https://github.com/phosphorjs/phosphor/blob/master/packages/virtualdom/src/index.ts#L27-L124
- React Typescript definition file from DefinitelyTyped: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts
- fuelDOM (React-compatible) Typescript definition file: https://github.com/brn/fuel/blob/dc7a2025407686dc086abe90d0a423f223b76fa5/lib/type.d.ts

gnestor added 2 commits

June 7, 2017 08:56


          Use camel case for element event names

df29364


          Use camel case for element attribute names

6d3d585

gnestor mentioned this pull request

TSX Support for Phosphor vdom API #279

Open

Contributor

ellisonbg commented Jun 7, 2017

Can we allow phosphor to accept the lowercase and react style names to avoid forcing a 2.0 release?

Member

sccolbert commented Jun 7, 2017

Yeah, we're gonna have to do something like that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.