Include optional dependencies in cycle check

[vidartf]

Fixes #389 by including optional dependencies in the plugin cycle check.

[sccolbert]

Could you replace the const with let? We only use const when absolutely necessary.

[sccolbert]

It's not for any particular reason, just that let is faster to type, and we already use it everywhere else.

[jasongrout]

let is faster to type

To be clear, we are talking about typing on a keyboard, not TypeScript typing.

[sccolbert]

Yes

…

On Fri, Jun 14, 2019 at 12:12 PM Jason Grout ***@***.***> wrote: let is faster to type To be clear, we are talking about typing on a keyboard, not TypeScript typing. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#390?email_source=notifications&email_token=AABBQSOGTBNFTU7EIJIDKOLP2PGRFA5CNFSM4HXZHRA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXNMLQ#issuecomment-502191662>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABBQSNS3MEOLSS5VEMWFIDP2PGRFANCNFSM4HXZHRAQ> .

[sccolbert]

And if my memory serves me correctly, `let` was added to Typescript before `const`, and a lot of the code was written before `const` became available. We could migrate to `const` in a PR dedicated to just that change.

…

On Fri, Jun 14, 2019 at 1:07 PM Chris Colbert ***@***.***> wrote: Yes On Fri, Jun 14, 2019 at 12:12 PM Jason Grout ***@***.***> wrote: > let is faster to type > > To be clear, we are talking about typing on a keyboard, not TypeScript > typing. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#390?email_source=notifications&email_token=AABBQSOGTBNFTU7EIJIDKOLP2PGRFA5CNFSM4HXZHRA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXNMLQ#issuecomment-502191662>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABBQSNS3MEOLSS5VEMWFIDP2PGRFANCNFSM4HXZHRAQ> > . >

[vidartf]

Sure, I agree that maintaining internal consistency is more important here than any of the other concerns I can think of. Pushed.