This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 166
Adds a "pass thru" virtual element #437
Open
telamonian
wants to merge
15
commits into
phosphorjs:master
Choose a base branch
from
telamonian:vdom-pass-thru
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 34c24fa - Browse repository at this point
Copy the full SHA 34c24faView commit details
Commits on Oct 12, 2019
-
hpass vdom elements are now functional; hpass was tested and is working
issues with vdom siblings still remain. siblings will get clobbered if/when the vdom updates. Still works well enough when the hpass element is the first sibling
Configuration menu - View commit details
-
Copy full SHA for ba3f51e - Browse repository at this point
Copy the full SHA ba3f51eView commit details -
added
Title.iconPass
prop; takes a{render: func(host)}
objthe value of `iconPass` is used to initialize an hpass vdom element in eg the tabbar renderer
Configuration menu - View commit details
-
Copy full SHA for cac9122 - Browse repository at this point
Copy the full SHA cac9122View commit details -
cleaned up
updateContent
/reduced the need for 'passthru' special ha……ndling accomplished this in part by moving a bunch of the complexity to the creatDOMNode function
Configuration menu - View commit details
-
Copy full SHA for 7dac2fa - Browse repository at this point
Copy the full SHA 7dac2faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 954563c - Browse repository at this point
Copy the full SHA 954563cView commit details
Commits on Oct 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 25d5dfa - Browse repository at this point
Copy the full SHA 25d5dfaView commit details -
made implementation of hpass more robust; now prevents sibling clobbe…
…ring still need to figure out how to handle cleanup; current implementation likely causes a memory leak due to uncleaned-up React components
Configuration menu - View commit details
-
Copy full SHA for 192025a - Browse repository at this point
Copy the full SHA 192025aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a72b59 - Browse repository at this point
Copy the full SHA 5a72b59View commit details
Commits on Oct 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c90601a - Browse repository at this point
Copy the full SHA c90601aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f6e210 - Browse repository at this point
Copy the full SHA 7f6e210View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a24a7b - Browse repository at this point
Copy the full SHA 7a24a7bView commit details -
fixed all typing/build errors in unittests
still getting some unittest failures in FocusTracker and TabBar in Widgets
Configuration menu - View commit details
-
Copy full SHA for 3c5fb72 - Browse repository at this point
Copy the full SHA 3c5fb72View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6945f2 - Browse repository at this point
Copy the full SHA a6945f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f96b33d - Browse repository at this point
Copy the full SHA f96b33dView commit details
Commits on Dec 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 71f427e - Browse repository at this point
Copy the full SHA 71f427eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.