Backups: Change file permissions for index database dumps #4243

Signed-off-by: Michael Mayer <michael@photoprism.app>
photoprism · May 19, 2024 · c2ef35d · c2ef35d
1 parent 957efaf
commit c2ef35d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/internal/photoprism/backup_database.go b/internal/photoprism/backup_database.go
@@ -102,7 +102,7 @@ func BackupDatabase(backupPath, fileName string, toStdOut, force bool, retain in
 	if toStdOut {
 		log.Infof("backup: sending database backup to stdout")
 		f = os.Stdout
-	} else if f, err = os.OpenFile(fileName, os.O_TRUNC|os.O_RDWR|os.O_CREATE, fs.ModeFile); err != nil {
+	} else if f, err = os.OpenFile(fileName, os.O_TRUNC|os.O_RDWR|os.O_CREATE, fs.ModeBackup); err != nil {
 		return fmt.Errorf("failed to create %s (%s)", clean.Log(fileName), err)
 	} else {
 		log.Infof("backup: %s database backup file %s", backupAction, clean.Log(filepath.Base(fileName)))

diff --git a/pkg/fs/mode.go b/pkg/fs/mode.go
@@ -2,7 +2,9 @@ package fs
 
 import "os"
 
+// File and directory permissions.
 var (
-	ModeDir  os.FileMode = 0o777
-	ModeFile os.FileMode = 0o666
+	ModeDir    os.FileMode = 0o777
+	ModeFile   os.FileMode = 0o666
+	ModeBackup os.FileMode = 0o600
 )