Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errata detailing addition of scalar type hints for PSR-11 (ContainerInterface) #1215

Merged
merged 1 commit into from Mar 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 26 additions & 0 deletions accepted/PSR-11-container-meta.md
Expand Up @@ -378,3 +378,29 @@ Are listed here all people that contributed in the discussions or votes (on cont
1. <a name="link_base_exception_usefulness"></a>[Discussion about the usefulness of the base exception](https://groups.google.com/forum/#!topic/php-fig/_vdn5nLuPBI)
1. <a name="link_not_found_behaviour"></a>[Discussion about the `NotFoundExceptionInterface`](https://groups.google.com/forum/#!topic/php-fig/I1a2Xzv9wN8)
1. <a name="link_get_optional_parameters"></a>Discussion about get optional parameters [in container-interop](https://github.com/container-interop/container-interop/issues/6) and on the [PHP-FIG mailing list](https://groups.google.com/forum/#!topic/php-fig/zY6FAG4-oz8)

## 11. Errata

## Type additions

The 1.1 release of the `psr/container` package includes scalar parameter types. The
2.0 release of the package includes return types. This structure leverages PHP
7.2 covariance support to allow for a gradual upgrade process.

Implementers MAY add return types to their own packages at their discretion,
provided that:

- the return types match those in the 2.0 package.
- the implementation specifies a minimum PHP version of 7.2.0 or later.

Implementers MAY add parameter types to their own packages in a new major
release, either at the same time as adding return types or in a subsequent
release, provided that:

- the parameter types match those in the 1.1 package.
- the implementation specifies a minimum PHP version of 7.2.0.
- the implementation depends on `"psr/container": "^1.1 || ^2.0"` so as to exclude
the untyped 1.0 version.

Implementers are encouraged but not required to transition their packages toward
the 2.0 version of the package at their earliest convenience.
8 changes: 8 additions & 0 deletions accepted/PSR-11-container.md
Expand Up @@ -104,6 +104,14 @@ interface ContainerInterface
}
~~~


Since [psr/container version 1.1](https://packagist.org/packages/psr/container#1.1.0),
the above interface has been updated to add argument type hints.

Since [psr/container version 2.0](https://packagist.org/packages/psr/container#2.0.0),
the above interface has been updated to add return type hints (but only to the
`has()` method).

<a name="container-exception"></a>
### 3.2. `Psr\Container\ContainerExceptionInterface`

Expand Down