Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop useless phpdoc, already covered by PHP #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented Feb 21, 2024

No description provided.

@lyrixx
Copy link
Contributor Author

lyrixx commented Apr 2, 2024

cc @Crell

@Crell
Copy link
Collaborator

Crell commented Apr 2, 2024

I agree the docblocks no longer offer any value. However, the docblocks were included in the original PSR text. There was a formal process to add the language types years later, once language types existed. 😄 I'm hesitant to remove the docblocks now when they are still specified in the spec.

@vdelau
Copy link
Member

vdelau commented Apr 2, 2024

@Seldaek is the editor for the related PSR

Copy link
Collaborator

@Seldaek Seldaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far I'm concerned I'd say ship it without vote etc.. It's an obvious cleanup of redundant info. If that's not ok per the rules someone will have to deal with a vote etc sorry i have no capacity atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants