we need a psr http factory implementation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Apr 3, 2021
composer.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "php-http/message": "^1.2", | |||
| "psr/http-client": "^1.0", | |||
| "psr/http-factory": "^1.0", | |||
There was a problem hiding this comment.
should we drop this? we need the psr/http-client because we implement the interfaces and provide the http-client-implementation.
however, it seems safe to assume that every http-factory-implementation depends on the http-factory interfaces package... not sure what is better.
dbu
commented
Apr 3, 2021
dbu
force-pushed
the
require-factory-implementation
branch
from
9108fd8
to
261fb07
Compare
dbu
force-pushed
the
require-factory-implementation
branch
from
261fb07
to
aa7d3c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This client assumes the existence of a HTTP factory. It either needs to be injected in the constructor or php-http autodiscovery is used to find one.