Tests: add dedicated test for the SyntaxError::translateTokens() method + edge case bug fix #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod This safeguards and documents the current behaviour of the method.
Generally speaking, the `$translate` parameter for the `SyntaxError::getNormalizedMessage()` method should only be passed as `true` when on a PHP version which doesn't do the PHP native token translation yet. However, in edge cases, it could be possible that tokens could be double "translated", both by PHP itself as well as by the `SyntaxError::translateTokens()` method. This minor fix prevents this by not matching token names when surrounded by parentheses. Includes additional unit tests.
jrfnl
force-pushed
the
feature/new-test-syntax-error-translatetokens
branch
from
b70c37e
to
2c1f747
Compare
grogy
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: add dedicated test for the SyntaxError::translateTokens() method
This safeguards and documents the current behaviour of the method.
SyntaxError::translateTokens(): prevent double translation
Generally speaking, the
$translateparameter for theSyntaxError::getNormalizedMessage()method should only be passed astruewhen on a PHP version which doesn't do the PHP native token translation yet.However, in edge cases, it could be possible that tokens could be double "translated", both by PHP itself as well as by the
SyntaxError::translateTokens()method.This minor fix prevents this by not matching token names when surrounded by parentheses.
Includes additional unit tests.