GH Actions: use fail-fast with setup-php when creating the binaries
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent build failure was due to the `setup-php` action running into a rate limit and not downloading the required version of Composer (`2.2`), which meant that the PHAR ended up being build with Composer 2.4. The `setup-php` action runner defaults to _showing_ these type errors in the logs, but not stopping the workflow run. For the creation of the binary it is really important that the correct Composer version is used as otherwise the PHAR file won't be compatible with PHP 5.3 - 5.5. So, specifically for those jobs, I'm adding the `fail-fast` option to `setup-php` to fail the build if the action runner ran into any errors. Ref: https://github.com/shivammathur/setup-php#fail-fast-optional
grogy
approved these changes
Dec 11, 2022
|
Thank you, merged :-) |
jrfnl
added a commit
that referenced
this pull request
Dec 20, 2022
Follow up on PR #131 Oops... realized I implemented it incorrectly. Fixed now.
grogy
pushed a commit
that referenced
this pull request
Dec 26, 2022
Follow up on PR #131 Oops... realized I implemented it incorrectly. Fixed now.
grogy
pushed a commit
that referenced
this pull request
Mar 27, 2024
Follow up on PR #131 Oops... realized I implemented it incorrectly. Fixed now.
jrfnl
added a commit
that referenced
this pull request
Mar 27, 2024
Follow up on PR #131 Oops... realized I implemented it incorrectly. Fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent build failure was due to the
setup-phpaction running into a rate limit and not downloading the required version of Composer (2.2), which meant that the PHAR ended up being build with Composer 2.4.The
setup-phpaction runner defaults to showing these type errors in the logs, but not stopping the workflow run.For the creation of the binary it is really important that the correct Composer version is used as otherwise the PHAR file won't be compatible with PHP 5.3 - 5.5.
So, specifically for those jobs, I'm adding the
fail-fastoption tosetup-phpto fail the build if the action runner ran into any errors.Ref: https://github.com/shivammathur/setup-php#fail-fast-optional