Align the percentage output

[robertology]

Left pad with whitespace so that the 100% line doesn't pop out of alignment.

Before:

............................................................  60/337 (17 %)
............................................................ 120/337 (35 %)
............................................................ 180/337 (53 %)
............................................................ 240/337 (71 %)
............................................................ 300/337 (89 %)
.....................................                        337/337 (100 %)

After:

............................................................  60/337 ( 17%)
............................................................ 120/337 ( 35%)
............................................................ 180/337 ( 53%)
............................................................ 240/337 ( 71%)
............................................................ 300/337 ( 89%)
.....................................                        337/337 (100%)

[jrfnl]

@robertology Thanks for the PR.

This change makes sense to me and looks correctly implemented.
Note: I haven't tested it locally.

Review notes:

• The 3 passed to stringWidth() for the $width parameter is redundant as it is the default value, but I kind of like it being explicitly passed as it makes it easier to understand the code.
• This PR removes the space between the $percent and the actual % sign. I'm ambivalent about this, but it is a change which is not necessarily needed to fix the issue this PR is trying to address.

I have a feeling there are no tests currently covering this change. Would now be a good time to add some tests ?

[grogy]

@jrfnl I suggest merge it with one change - add space between percent value and percent mark. What do you mean?

[jrfnl]

@jrfnl I suggest merge it with one change - add space between percent value and percent mark. What do you mean?

Sounds good to me.

[robertology]

Sorry, I never got back to you on the comment from months ago.

For the space before the %, I would say that is extremely unusual. Just like I wouldn't expect to see $ 15.34; there usually isn't whitespace separating those symbols. The changes here have the output matching the style of the phpunit output. But if you'd like to have the additional space in there, I can put it back.

And by the way, if I recall correctly, I put the explicit 3 in there because I saw it done elsewhere in the code and that was an attempt to match the existing codebase.

[grogy]

Thank you, your opinion sounds good. I merge it