Fix unit tests in master branch - unit tests library issue #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is necesary setup library for PHP unit tests.
|
Thank you. Do you have right. I missed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed description ~15min after creating a PR. PR solve 2 issues:
1. issue with Nette Tester
Is necesary setup library for PHP unit tests.
Library Nette Tester is used of 1.x version (on master branch).
An error in Nette Tester is the reason for failing unit tests.
This PR will not be pushed to
developbranch. It used PHPUnit library.2. issue with incorrect property name
Second commit resolve issue with missing property. Mistake comes from https://github.com/JakubOnderka/PHP-Parallel-Lint/pull/94/files#diff-0f72a4d5de7cb5a661be1a8151dc9a3c0c38d7dd00b005f0c1ce39082021872aR61 that is a typo.