Skip shebang sequence if it is the first line #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xaben Thank you for the PR. This looks like a good change to me. Could you add a unit test for this ? There is a test file dealing with the lint skipping here and you can probably add an extra test to that: https://github.com/php-parallel-lint/PHP-Parallel-Lint/blob/develop/tests/Unit/Process/SkipLintProcessTest.php |
|
Hi @jrfnl , I have a test for the shebang skip in the PR, is it in the wrong test file? PS Sorry I'm not using GitHub day to day so haven't seen your reply until now. |
jrfnl
approved these changes
Mar 16, 2024
|
Rebased without changes to get a passing build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linting executable files the first line is not always the php opening tag.
On such occasions we need to skip the shebang line, and read next line.