[PHP 8.4] Fixes for implicit nullability deprecation

[Ayesh]

Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations.

See:

• RFC
• PHP 8.4: Implicitly nullable parameter declarations deprecated

[jrfnl]

@Ayesh Thanks for the PR. Unfortunately, this PR cannot be accepted.

PHP-Parallel-Lint/composer.json

Line 13 in 539292f

"php": ">=5.3.0",

[jrfnl]

@Ayesh Would you be okay with me updating this PR to get it into a mergable state ?

@grogy Once this patch is ready, we should merge it, cherrypick it to master and release it as soon as possible as people using PHP Parallel Lint to already check their code against PHP 8.4 will currently get failing builds due to this deprecation.

As develop and master have some differences at this time, I'll open a ticket in a moment with a proposal on how to deal with this and what's needed (in my opinion) to do a release.

[Ayesh]

Please feel free to update the PR. If it makes things easier/cleaner, lets just close this one. Completely trusting you hands that you will sort balance the deprecation notices and the best compatibility.

[jrfnl]

Please feel free to update the PR. If it makes things easier/cleaner, lets just close this one. Completely trusting you hands that you will sort balance the deprecation notices and the best compatibility.

Thanks @Ayesh ! I've just pushed an update. Let's hope the build passes ;-)

[jrfnl]

I've just cherrypicked the commit from PR #152 into this one to get the builds running properly. 🤞🏻

[jrfnl]

Test failure on PHP 8.4 looks to be related to incompatibilities in the last version of PHPUnit 9 (will likely be fixed soon), not related to this package itself.

[jrfnl]

I've done a test run which combines the changes from PR #152, #157 and this PR and that gets us a passing build on PHP 8.4, which confirms that this patch fixes the PHP 8.4 issue.

https://github.com/php-parallel-lint/PHP-Parallel-Lint/actions/runs/8310177747

[jrfnl]

Thanks @Ayesh for the PR and starting the conversation about fixing this deprecation.

Patch as-is is good to go and has been confirmed as working cross-version (see my previous comment).

Waiting to merge as PRs #152 and #158 will need to be merged first to get a passing build.

[Ayesh]

This is amazing, thank you!

[grogy]

Thank to both, it looks great. I merge it.