Implement daemon mode #351
Conversation
|
Any word about it in the README? |
|
We can't use code from a different license if it's just simply copied. If it's inspired or is a construct that is used also everywhere else (like in the documentation, tutorials etc) then we don't need the reference to phlib/console-process as those stuff is not licensable. I personally don't see anything that is defendable although I haven't checked the origin and don't know how hard you copied, if you even did. |
Imho they could chose to relicense for us. I've opened an issue at that project. If you have objections please feel free to close but I'm lacking capacity to start over :/ |
|
Hi, I'm a maintainer at phlib/console-process It's fine with us! See comment at phlib/console-process#4 Cheers, |
andig
force-pushed
the
daemon
branch
3 times, most recently
from
665c8fd
to
4f36839
Compare
|
I've updated and simplified the PR. |
andig
force-pushed
the
daemon
branch
5 times, most recently
from
83b15b1
to
30d126a
Compare
|
What is the main processes dies? Will it automatically restart? |
|
No, thats nothing I‘ve considered. Should be done via systemctrl daemon setting? |
|
When will it be merged to master? I need it |
|
Hi @andig should we move forward with this one? |
| if ($output->isVerbose()) { | ||
| $output->writeln('Daemonized'); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
As this project supports Symfony 5, the return value of a commands execute method must be an integer. While it is not part of the methods signature in the abstract Command class, it is still validated and an exception will be thrown for any non-integer return value. So I suggest, you change this to return 0; along with the other return statement below.
Up to you. We‘ve had this around for so long I wouldn‘t mind closing although there seems to be some positive comments. |
Some code is borrowed from https://github.com/phlib/console-process (LGPL)- need to double-check if that is ok