Add TCP Context in the configuration

[kdubuc]

Add the possibility to provide the TCP context in the start process of ProcessManager, and gives the opportunity to build Secure Socket. Related #462

Usage : This PR add --tcp-context option which accept an JSON array encoded.

Example : php bin/ppm start --tcp-context '{"tls":{"local_cert": "test.pem"}}'

This is the first shot.

What do you think ?

Also, I have some difficulty to make the ConfigTrait testable, if you have some ideas, I will take them.

[kdubuc]

Hum, i'm not sure I am responsible for the failed tests. It seems Symfony 5 enforce execute returns only integers, and not null on commands.

[andig]

There are some other issues like https://travis-ci.org/php-pm/php-pm/jobs/617713470#L365, please take a look. I don't see any related to Symfony.

[kdubuc]

Yeah, I forgot to manage PHP 7.1. I added a condition to polyfill (sort of) when
JSON_THROW_ON_ERROR is not defined.

But I keep having some bugs with return value of execute's command :

PHP Fatal error: Uncaught TypeError: Return value of "PHPPM\Commands\StatusCommand::execute()" must be of the type int, NULL returned. in /home/travis/build/php-pm/php-pm/vendor/symfony/console/Command/Command.php:258

[andig]

But I keep having some bugs with return value of execute's command

That would need a separate PR, didn't catch that when Symfony 5 was allowed. See #479.

[kdubuc]

I updated my PR with your changes 😉

[andig]

Looking good to me. I imagine a more typical scenario would be to deploy ppm behind an SSL-terminating reverse proxy (Traefik etc).

ping @marcj for approval

[kdubuc]

Any news on this ? @marcj ?

[acasademont]

@andig this could also allow a different TCP backlog option than the proposed 511 default we spoke about. I guess this PR should be reworked a bit to allow that backlog default

For reference, I'm speaking about #488

[andig]

Agreed. It would make sense to allow configuration of all aspects of the server configuration.

[acasademont]

@kdubuc would you be able to work on those changes?

[kdubuc]

Yes, I just need some free times but I will work on this PR ;)

[andig]

ping @kdubuc ;)