Start with a basic bridge so that we don't depend on external packages #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acasademont
force-pushed
the
saner_defaults
branch
from
e1fc6ff
to
e9273a0
Compare
jkrzefski
reviewed
Aug 7, 2020
| @@ -16,7 +16,7 @@ trait ConfigTrait | |||
| protected function configurePPMOptions(Command $command) | |||
| { | |||
| $command | |||
| ->addOption('bridge', null, InputOption::VALUE_REQUIRED, 'Bridge for converting React Psr7 requests to target framework.', 'HttpKernel') | |||
| ->addOption('bridge', null, InputOption::VALUE_REQUIRED, 'Bridge for converting React Psr7 requests to target framework. (e.g., HttpKernel)', 'StaticBridge') | |||
There was a problem hiding this comment.
I just want to point out that this warrants to major version bump for me. Changing the default behavior when this option is not provided has the potential to break existing setups.
There was a problem hiding this comment.
@jkrzefski you're totally right, although it sounds weird that someone would start ppm with the defaults for anything serious, logging and debugging are also on by default
There was a problem hiding this comment.
I can totally imagine people only setting those options whose default values don't match their use case. So debug behavior and logging might be disabled explicitly but the bridge selection is left unchanged, since it "works by default".
|
How shall we proceed with this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when freshly installing php-pm, you can't even run the
bin/ppm startcommand because the defaults (HttpKernel bridge) will make it crash if not present. By using a StaticBridge default, we provide a nicer experience to the end user. It's not a very useful bridge, but at least it doesn't crash on a loop.