look for translation files with intl domain suffix, too #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: with this PR and symfony/symfony#35370 the web UI and edit in place now both work for me using Intl ICU domains. |
|
Thank you for your contribution! Could you fix phpstan and php-cs-fixer errors? We will merge your PR as soon as theses checks will be green 😉 |
|
@welcoMattic checks are green now |
welcoMattic
approved these changes
Jan 19, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the translation update logic for picking the file to write into. The new version looks for Intl ICU files first. For example it detects
messages+intl-icu.de.yamland prefers this againstmessages.de.yaml.