Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURL sync with EN #933

Merged
merged 2 commits into from
May 20, 2024
Merged

CURL sync with EN #933

merged 2 commits into from
May 20, 2024

Conversation

devnexen
Copy link
Member

No description provided.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits but LGTM

Comment on lines 227 to 231
</refentry>
</refentry>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: unintentional indent change?

Actually, I'm confused by the latter part of the diff here

Comment on lines 1295 to 1296
</simpara>
</warning>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: slight indent issue

Suggested change
</simpara>
</warning>
</simpara>
</warning>

@devnexen devnexen merged commit 09057f0 into php:master May 20, 2024
1 check passed
@devnexen devnexen deleted the curl_upd5 branch May 26, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants