Amend PDO driver-specific class names #14069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
requested review from
SakiTakamachi,
devnexen and
NattyNarwhal
as code owners
kocsismate
force-pushed
the
pdo-subclass-amendment
branch
3 times, most recently
from
f519b84
to
0ff7c0b
Compare
|
If Tim's RFC is passed, the In that case the stub would look like this: This may not happen due to backward compatibility issues, but I'd like to comment as a memorandum. |
|
Was there any conclusion in the thread? It would be nice if we could implement these changes. |
|
I haven't received a response so I'll try emailing again. |
|
It's been a week since I sent the email, and so far there have been no objections. In my opinion, it's ok to merge this, but should we wait a bit longer? |
SakiTakamachi
approved these changes
May 29, 2024
kocsismate
force-pushed
the
pdo-subclass-amendment
branch
from
0ff7c0b
to
aad9460
Compare
NattyNarwhal
approved these changes
May 30, 2024
kocsismate
force-pushed
the
pdo-subclass-amendment
branch
from
79e242d
to
e022180
Compare
|
@kocsismate You'll also need to adjust the names in NEWS/UPGRADING. |
|
@TimWolla Yeah, I know I forgot, but it's going to be fixed soon: #14299 (comment) |
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Jun 2, 2024
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Jun 2, 2024
Follow-up to phpGH-14069. Signed-off-by: Ayesh Karunaratne <ayesh@aye.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in https://externals.io/message/123166