Check Apache HTTP Server command-line utility #14173
Open
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Apache HTTP server command-line tool (/usr/sbin/apache2) might be part of a separate package, such as apache2-bin or similar. If not installed, the configure script can still find the apxs tool, but previously didn't check for the HTTP server tool separately. Otherwise, configure syntax errors (integer expression expected) are thrown when checking for the Apache version. Version checks have been replaced with Autoconf's AS_VERSION_COMPARE macro.
devnexen
reviewed
May 8, 2024
| @@ -58,9 +63,10 @@ if test "$PHP_APXS2" != "no"; then | |||
|
|
|||
| dnl Test that we're trying to configure with apache 2.x | |||
| PHP_AP_EXTRACT_VERSION($APXS_HTTPD) | |||
| if test "$APACHE_VERSION" -lt 2000044; then | |||
| AS_VERSION_COMPARE([$APACHE_VERSION], [2000044], [ | |||
There was a problem hiding this comment.
off-topic a bit, 2.0.x is really ancient even 2.2.x is.
There was a problem hiding this comment.
Yes, this should be updated also at some point. Also for Windows. To something like 2.4.
There was a problem hiding this comment.
I'll open a separate discussion for dropping support for EOL Apache branches 2.0 and 2.2. I'm not fully sure yet what all this can impact, but Apache 2.2 is definitely EOL since 2018 and shouldn't be encouraged to use anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Apache HTTP server command-line tool (/usr/sbin/apache2) might be part of a separate package, such as apache2-bin or similar. If not installed, the configure script can still find the apxs tool, but previously didn't check for the HTTP server tool separately. Otherwise, configure syntax errors (integer expression expected) are thrown when checking for the Apache version. Version checks have been replaced with Autoconf's AS_VERSION_COMPARE macro.