Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing MYSQLND_SHARED_LIBADD substitution #14228

Merged
merged 1 commit into from
May 17, 2024

Conversation

petk
Copy link
Member

@petk petk commented May 14, 2024

This is used in Makefile when building mysqlnd as shared to get zlib and crypto libraries linked in the mysqlnd.so (-lz -lcrypto). For static build these are in the resulting binary like before.

./buildconf
./configure --enable-mysqlnd=shared --with-openssl
grep MYSQLND_SHARED_LIBADD Makefile

This is used in Makefile when building mysqlnd as shared to get zlib and
crypto libraries linked in the mysqlnd.so (-lz -lcrypto). For static
build these are in the resulting binary like before.
@petk petk marked this pull request as ready for review May 14, 2024 10:57
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@petk petk merged commit b5b9c13 into php:master May 17, 2024
10 checks passed
@petk petk deleted the patch-mysqlnd-subst branch May 17, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants