Sync HAVE_* symbols for extensions #14233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This syncs missing build system gaps of some extensions' definitions being defined on Windows and some on *nix. To not cause too much divergence with the current default ext/skeleton template, they weren't removed even though they aren't used. Help texts are also synced a bit where possible. * HAVE_INTL (added to Autotools also) * HAVE_PDO_DBLIB (added to Windows build also) * HAVE_PDO_FIREBIRD (added to Windows build also) * HAVE_TOKENIZER (added to Autotools also)
github-actions
bot
added
Extension: intl
Extension: pdo_dblib
Extension: pdo_firebird
labels
|
PHP_INTL had been present solely on windows for a long time (can be seen in PHP 4) but never used, seems same story for others. I do not see an issue removing these. |
This syncs build system gaps of some extensions' definitions being defined on Windows and some on *nix. These are not used anywhere and are only defined in some build system and not the other: * HAVE_INTL (was present only on Windows) * HAVE_PDO_DBLIB (was present only on Autotools) * HAVE_PDO_FIREBIRD (was present only on Autotools) * HAVE_TOKENIZER (was present only on Windows)
|
Ok, yes. I think so too... |
devnexen
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some extension
HAVE_<extension>symbols left:These are not used anywhere and are defined only in some build system and not the other.
Should these be removed or synced to be available via both builds?