Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vm flags for zend_optimizer_migrate_jump() #14237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented May 14, 2024

@dstogov I'm planning on using making a bunch of such suggestions, if you think they are ok. The goal is to minimize changes in optimizer when adding new opcodes, because:

  1. It's tedious.
  2. Most contributors shouldn't need to understand the optmizer, and minimizing the necessary changes will simplify things for them.

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the proposed code is going to be slower.
Instead, it may make sense to add assertions into default path.
This way we will be sure that nothing is missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants