Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/duplicated array keys #484

Merged
merged 9 commits into from
Jun 11, 2017
Merged

Feature/duplicated array keys #484

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
44f20a9
Detectign duplicated array keys.
rafalwrzeszcz Feb 29, 2016
5570e3e
Oh, we still support PHP 5.3… so 2009 ;).
rafalwrzeszcz Feb 29, 2016
dc87a6d
Added `public` modifier, just so Scrutinizer don't complain.
rafalwrzeszcz Feb 29, 2016
48e6db8
Moved rule to CleanCode section.
rafalwrzeszcz Feb 29, 2016
b1ea2ef
Closes https://github.com/phpmd/phpmd/pull/350
eeree Jun 5, 2017
103930e
Make Stickler Bot happy
eeree Jun 5, 2017
ddb8c51
Resolves https://github.com/phpmd/phpmd/pull/484#pullrequestreview-42…
eeree Jun 11, 2017
3c5a822
Merge remote-tracking branch 'upstream/master' into feature/duplicate…
eeree Jun 11, 2017
a040a41
Resolves https://github.com/phpmd/phpmd/pull/484#pullrequestreview-43…
eeree Jun 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../testRuleAppliesMultipleTimesToMethodWithAssotiativeArrayDefinitionWithDuplicatedKeys.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

class testRuleAppliesMultipleTimesToMethodWithAssotiativeArrayDefinitionWithDuplicatedKeys
{
function testRuleAppliesMultipleTimesToMethodWithAssotiativeArrayDefinitionWithDuplicatedKeys()
public function testRuleAppliesMultipleTimesToMethodWithAssotiativeArrayDefinitionWithDuplicatedKeys()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't do this just to satisfy some CI, but this actually communicates intention explicitly.

{
return array(
'foo' => 42,
Expand Down
2 changes: 1 addition & 1 deletion ...catedArrayKey/testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedKeys.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

class testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedKeys
{
function testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedKeys()
public function testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedKeys()
{
return array(
'foo' => 42,
Expand Down
2 changes: 1 addition & 1 deletion ...ey/testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedMixedQuotedKeys.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

class testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedMixedQuotedKeys
{
function testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedMixedQuotedKeys()
public function testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedMixedQuotedKeys()
{
return array(
'foo' => 42,
Expand Down
2 changes: 1 addition & 1 deletion ...yKey/testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedMixedTypeKeys.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

class testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedMixedTypeKeys
{
function testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedMixedTypeKeys()
public function testRuleAppliesToMethodWithAssotiativeArrayDefinitionWithDuplicatedMixedTypeKeys()
{
return array(
123 => 42,
Expand Down
2 changes: 1 addition & 1 deletion ...rrayKey/testRuleNotAppliesToMethodWithAssotiativeArrayDefinitionWithoutDuplicatedKeys.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

class testRuleNotAppliesToMethodWithAssotiativeArrayDefinitionWithoutDuplicatedKeys
{
function testRuleNotAppliesToMethodWithAssotiativeArrayDefinitionWithoutDuplicatedKeys()
public function testRuleNotAppliesToMethodWithAssotiativeArrayDefinitionWithoutDuplicatedKeys()
{
return array(
'foo' => 42,
Expand Down
2 changes: 1 addition & 1 deletion ...Design/DuplicatedArrayKey/testRuleNotAppliesToMethodWithNonAssotiativeArrayDefinition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

class testRuleNotAppliesToMethodWithNonAssotiativeArrayDefinition
{
function testRuleNotAppliesToMethodWithNonAssotiativeArrayDefinition()
public function testRuleNotAppliesToMethodWithNonAssotiativeArrayDefinition()
{
return array(
42,
Expand Down
2 changes: 1 addition & 1 deletion ...files/Rule/Design/DuplicatedArrayKey/testRuleNotAppliesToMethodWithoutArrayDefinition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

class testRuleNotAppliesToMethodWithoutArrayDefinition
{
function testRuleNotAppliesToMethodWithoutArrayDefinition()
public function testRuleNotAppliesToMethodWithoutArrayDefinition()
{
}
}