-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip is not present for datetime and timestamp fields #17910
Comments
Hi @aksy2512 |
Ok, I will start with this issue |
@williamdes Can you please guide me about which file should I change for this issue since the codebase is large and how can I see my changes? Sorry for disturbing you |
Do you have a web server setup, yarn and composer and git installed? |
I don't have a web server setup |
Well you will need a web server setup with php, mysql and have installed git, yarn, composer, nodejs |
I have installed Apache for the web server and all the other tools. Please guide me through the next steps |
Perfect |
Yes, I have done that as well. Thank you |
@williamdes Hi, Can you please help me with the issue? I am not able to find out the file in which I have to write the code |
You can find it here: phpmyadmin/js/src/functions.js Line 167 in f6a03d4
|
Is it on some other branch than master? |
My link is on another branch but use code search in your IDE to find the same price of code :) |
Hi, I am trying to work on this improvement. This is my first time I am contributing to a GitHub project. I added the CSS below to jquery-ui.css
I have one question. I am able to see the code for the date and time image in the browser by inspecting it, but I am not able to find the code in my text editor. I am talking about this code snippet. The pointer is of type pointer; by adding the above CSS, please let me know if this is the correct place to make changes. I will raise the PR, please let me know. @williamdes can you please help me with this. |
Hi @jdideepak I am not sure the pointer is what this issue is reporting |
Hello @williamdes,
This is a suggestion for a UI enhancement. Currently, when hovering over the calendar icon, the cursor is set to an arrow. It would be better if the cursor changed to a pointer instead, to provide clearer visual feedback to the user. |
Okay, this is not related to this issue. Feel free to open a pull-request for this good UI enhancement |
Hi @williamdes, I have added the Tooltip for both timestamp and datetime fields. I used the Tooltip message which is used for the "date" field, let me know if this is fine or if I should change the message to something like this "MySQL accepts additional values not selectable by the datepicker / slider; key in those values directly if desired". If it is okay, I will create a Pull request. |
Very nice ! Maybe change "key in" to "type" |
Hi @williamdes, Pull request for Adding a tooltip for datetime and timestamp fields: #18295 |
Screenshots
02.09.2022_08.22.30_REC.mp4
Tooltip is not present for datetime and timestamp.
20.11.2022_16.22.28_REC.mp4
Server configuration
The text was updated successfully, but these errors were encountered: