Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip is not present for datetime and timestamp fields #17910

Open
liviuconcioiu opened this issue Nov 20, 2022 · 20 comments · May be fixed by #18295
Open

Tooltip is not present for datetime and timestamp fields #17910

liviuconcioiu opened this issue Nov 20, 2022 · 20 comments · May be fixed by #18295
Labels
affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface

Comments

@liviuconcioiu
Copy link
Contributor

liviuconcioiu commented Nov 20, 2022

Screenshots

02.09.2022_08.22.30_REC.mp4

Tooltip is not present for datetime and timestamp.

20.11.2022_16.22.28_REC.mp4

Server configuration

  • phpMyAdmin version: QA_5_2
@williamdes williamdes added Bug A problem or regression with an existing feature affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set labels Nov 20, 2022
@williamdes williamdes changed the title Tooltip issues Tooltip is not present for datetime and timestamp fields Nov 20, 2022
@williamdes
Copy link
Member

Hi @aksy2512
You may prefer to contribute on this one as it's an easier one

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface good first issue and removed Bug A problem or regression with an existing feature affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set labels Dec 10, 2022
@aksy2512
Copy link

Hi @aksy2512 You may prefer to contribute on this one as it's an easier one

Ok, I will start with this issue

@aksy2512
Copy link

@williamdes Can you please guide me about which file should I change for this issue since the codebase is large and how can I see my changes? Sorry for disturbing you

@williamdes
Copy link
Member

@williamdes Can you please guide me about which file should I change for this issue since the codebase is large and how can I see my changes? Sorry for disturbing you

Do you have a web server setup, yarn and composer and git installed?

@aksy2512
Copy link

@williamdes Can you please guide me about which file should I change for this issue since the codebase is large and how can I see my changes? Sorry for disturbing you

Do you have a web server setup, yarn and composer and git installed?

I don't have a web server setup

@williamdes
Copy link
Member

Well you will need a web server setup with php, mysql and have installed git, yarn, composer, nodejs

@aksy2512
Copy link

aksy2512 commented Dec 10, 2022

Well you will need a web server setup with php, mysql and have installed git, yarn, composer, nodejs

I have installed Apache for the web server and all the other tools. Please guide me through the next steps

@williamdes
Copy link
Member

Well you will need a web server setup with php, mysql and have installed git, yarn, composer, nodejs

I have installed Apache for the web server and all the other tools. Please guide me through the next steps

Perfect
You will need to fork this repository and clone it on your workstation
Then open a terminal in the folder and do composer update && yarn install

@aksy2512
Copy link

Well you will need a web server setup with php, mysql and have installed git, yarn, composer, nodejs

I have installed Apache for the web server and all the other tools. Please guide me through the next steps

Perfect You will need to fork this repository and clone it on your workstation Then open a terminal in the folder and do composer update && yarn install

Yes, I have done that as well. Thank you

@aksy2512
Copy link

@williamdes Hi, Can you please help me with the issue? I am not able to find out the file in which I have to write the code

@williamdes
Copy link
Member

@williamdes Hi, Can you please help me with the issue? I am not able to find out the file in which I have to write the code

You can find it here:

var $note = $('<p class="note"></div>');

@aksy2512
Copy link

@williamdes Hi, Can you please help me with the issue? I am not able to find out the file in which I have to write the code

You can find it here:

var $note = $('<p class="note"></div>');

Is it on some other branch than master?

@williamdes
Copy link
Member

My link is on another branch but use code search in your IDE to find the same price of code :)

@jdideepak
Copy link

jdideepak commented Jan 4, 2023

Hi, I am trying to work on this improvement. This is my first time I am contributing to a GitHub project.

I added the CSS below to jquery-ui.css

.ui-datepicker-trigger { cursor: pointer; }

I have one question. I am able to see the code for the date and time image in the browser by inspecting it, but I am not able to find the code in my text editor. I am talking about this code snippet. <img class="ui-datepicker-trigger" src="./themes/pmahomme/img/b_calendar.png" alt="..." title="...">. Please let me know how this code is generated for the frontend.

The pointer is of type pointer; by adding the above CSS, please let me know if this is the correct place to make changes.

image

I will raise the PR, please let me know.

@williamdes can you please help me with this.

@williamdes
Copy link
Member

Hi @jdideepak
Did you watch the videos on #17910 (comment) ?

I am not sure the pointer is what this issue is reporting

@jdideepak
Copy link

Hello @williamdes,

Did you watch the videos on https://github.com/phpmyadmin/phpmyadmin/issues/17910#issue-1456958595 ?
Yes I did.

This is a suggestion for a UI enhancement. Currently, when hovering over the calendar icon, the cursor is set to an arrow. It would be better if the cursor changed to a pointer instead, to provide clearer visual feedback to the user.

image

@williamdes
Copy link
Member

This is a suggestion for a UI enhancement. Currently, when hovering over the calendar icon, the cursor is set to an arrow. It would be better if the cursor changed to a pointer instead, to provide clearer visual feedback to the user.

Okay, this is not related to this issue. Feel free to open a pull-request for this good UI enhancement

@hrushi2311
Copy link

Hi @williamdes,

I have added the Tooltip for both timestamp and datetime fields.

Screenshot 2023-03-29 162906

Screenshot 2023-03-29 163114

Screenshot 2023-03-29 163025

Screenshot 2023-03-29 164105

I used the Tooltip message which is used for the "date" field, let me know if this is fine or if I should change the message to something like this "MySQL accepts additional values not selectable by the datepicker / slider; key in those values directly if desired".

If it is okay, I will create a Pull request.

@williamdes
Copy link
Member

If it is okay, I will create a Pull request.

Very nice !
You can create a branch from the master branch and open a pull-request for it

Maybe change "key in" to "type"
Something that users with poor or simple English can better understand

@hrushi2311
Copy link

hrushi2311 commented Mar 29, 2023

Hi @williamdes,

Pull request for Adding a tooltip for datetime and timestamp fields: #18295

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set enhancement A feature request for improving phpMyAdmin good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants