Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17910 - Added Tooltips for Datetime and Timestamp fields #18295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hrushi2311
Copy link

@hrushi2311 hrushi2311 commented Mar 29, 2023

Added Tooltips for both datetime and timestamp fields.

image

image

image

image

Fixes: #17910

@MauricioFauth
Copy link
Member

Hello. Thanks for your contribution!

We require a full name for legal compliance reasons. Could you use your full name in the signature tag?
For example: Signed-off-by: Jane Developer <jane@example.com>

You can do it by running, for example:

git commit -s --amend
git push -f origin tooltip_for_datetime_and_timestamp

See Developer's Certificate of Origin

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (03db39a) 54.98% compared to head (01b411d) 54.98%.

❗ Current head 01b411d differs from pull request most recent head a828fa6. Consider uploading reports for the commit a828fa6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18295      +/-   ##
============================================
- Coverage     54.98%   54.98%   -0.01%     
  Complexity    16401    16401              
============================================
  Files           628      628              
  Lines         64550    64554       +4     
============================================
+ Hits          35491    35492       +1     
- Misses        29059    29062       +3     
Flag Coverage Δ
dbase-extension 54.98% <100.00%> (+0.02%) ⬆️
recode-extension 54.94% <100.00%> (+0.02%) ⬆️
unit-8.1-ubuntu-latest 54.94% <100.00%> (+<0.01%) ⬆️
unit-8.2-ubuntu-latest 54.92% <100.00%> (-0.01%) ⬇️
unit-nightly-ubuntu-latest 54.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...asses/Controllers/JavaScriptMessagesController.php 99.68% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hrushi2311 hrushi2311 changed the title Added Tooltips for Datetime and Timestamp fields Signed-off-by: Hrushikesh <Hrushi.23paturu@gmail.com>Added Tooltips for Datetime and Timestamp fields Mar 30, 2023
@hrushi2311 hrushi2311 changed the title Signed-off-by: Hrushikesh <Hrushi.23paturu@gmail.com>Added Tooltips for Datetime and Timestamp fields Added Tooltips for Datetime and Timestamp fields Mar 30, 2023
@hrushi2311 hrushi2311 force-pushed the tooltip_for_datetime_and_timestamp branch 2 times, most recently from ac4509d to 9355e63 Compare March 30, 2023 09:32
Signed-off-by: Hrushikesh <hrushi.23paturu@gmail.com>
Signed-off-by: hrushi2311 <hrushi.23paturu@gmail.com>
@hrushi2311 hrushi2311 force-pushed the tooltip_for_datetime_and_timestamp branch from 9355e63 to a828fa6 Compare March 30, 2023 09:37
@williamdes williamdes added the enhancement A feature request for improving phpMyAdmin label Apr 7, 2023
@williamdes williamdes changed the title Added Tooltips for Datetime and Timestamp fields Fix #17910 - Added Tooltips for Datetime and Timestamp fields Apr 7, 2023
@williamdes williamdes added this to the 6.0.0 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request for improving phpMyAdmin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip is not present for datetime and timestamp fields
4 participants