Search validate ints #18584
Draft
Search validate ints #18584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
- Allow spaces around numbers - Allow plus/minus for hex numbers - Allow multiple plus minus signs for single number - Disallow trailing comma - Disallow arbitrary text before single numbers Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## QA_5_2 #18584 +/- ##
============================================
- Coverage 48.03% 47.31% -0.72%
Complexity 17011 17011
============================================
Files 607 607
Lines 72341 72341
============================================
- Hits 34747 34227 -520
- Misses 37594 38114 +520
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
williamdes
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #18542, need more changes in 6.0.0
I converted the tests from https://regexr.com/7h1ci and https://regexr.com/7h1eq to node/js tests.
Not quite sure if I'm doing the exporting/importing of the functions right, I tried to match how it's done in functions.js. It works...