Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing geometries #18624

Draft
wants to merge 4 commits into
base: QA_5_2
Choose a base branch
from

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Aug 14, 2023

Fixes

  • Empty geometry collection columns cannot be edited because no select input for the geometry type is available
  • The test for generateWkt was only executed for GeometryCollection, other classes had providers but no test method
  • An error occured when switching geometry type of a geometry inside a GeometryCollection to MultiLineString or MultiPolygon
  • The geometry type should only be selectable for columns of type Geometry

I reorganized the Gis tests to have only one test method in GisGeomTestCase.php in most cases

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.03% 🎉

Comparison is base (58570cf) 48.58% compared to head (7ce9cb3) 48.62%.
Report is 4 commits behind head on QA_5_2.

Additional details and impacted files
@@             Coverage Diff              @@
##             QA_5_2   #18624      +/-   ##
============================================
+ Coverage     48.58%   48.62%   +0.03%     
  Complexity    17011    17011              
============================================
  Files           607      607              
  Lines         72340    72341       +1     
============================================
+ Hits          35144    35173      +29     
+ Misses        37196    37168      -28     
Flag Coverage Δ
dbase-extension 48.17% <66.66%> (+0.05%) ⬆️
recode-extension 48.18% <66.66%> (-0.99%) ⬇️
unit-7.2-ubuntu-latest 49.32% <66.66%> (+1.26%) ⬆️
unit-7.3-ubuntu-latest 49.85% <66.66%> (+1.35%) ⬆️
unit-7.4-ubuntu-latest 49.80% <66.66%> (+1.30%) ⬆️
unit-8.0-ubuntu-latest 49.90% <66.66%> (+1.38%) ⬆️
unit-8.1-ubuntu-latest 48.58% <66.66%> (+0.04%) ⬆️
unit-8.2-ubuntu-latest 48.59% <66.66%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...es/classes/Controllers/GisDataEditorController.php 9.52% <0.00%> (-0.12%) ⬇️
libraries/classes/Gis/GisMultiLineString.php 97.67% <100.00%> (+11.04%) ⬆️
libraries/classes/Gis/GisMultiPolygon.php 90.23% <100.00%> (+11.32%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant