Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix#18450 - Central column with a default value cannot be created #19059

Draft
wants to merge 1 commit into
base: QA_5_2
Choose a base branch
from

Conversation

LHofman
Copy link
Contributor

@LHofman LHofman commented Mar 16, 2024

Description

Central column with a default value cannot be created

Fixes #18450

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Lennert Hofman <hofmanlennert@gmail.com>
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.63%. Comparing base (5f43edb) to head (3687f42).
Report is 15 commits behind head on QA_5_2.

Additional details and impacted files
@@             Coverage Diff              @@
##             QA_5_2   #19059      +/-   ##
============================================
+ Coverage     48.33%   48.63%   +0.30%     
- Complexity    17026    17027       +1     
============================================
  Files           607      607              
  Lines         72361    72363       +2     
============================================
+ Hits          34975    35196     +221     
+ Misses        37386    37167     -219     
Flag Coverage Δ
dbase-extension 48.71% <ø> (+0.03%) ⬆️
recode-extension 48.14% <ø> (-0.50%) ⬇️
unit-7.2-ubuntu-latest 48.13% <ø> (-1.13%) ⬇️
unit-7.3-ubuntu-latest 49.79% <ø> (+1.24%) ⬆️
unit-7.4-ubuntu-latest 48.56% <ø> (+0.06%) ⬆️
unit-8.0-ubuntu-latest 48.56% <ø> (-0.05%) ⬇️
unit-8.1-ubuntu-latest 48.59% <ø> (+0.05%) ⬆️
unit-8.2-ubuntu-latest 48.54% <ø> (+0.03%) ⬆️
unit-8.3-ubuntu-latest 49.30% <ø> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only partially fixes the issue. It doesn't fix the second part where a PHP error is raised.

@LHofman
Copy link
Contributor Author

LHofman commented Mar 31, 2024

Must have missed that part. I'll take a look soon

@williamdes williamdes marked this pull request as draft April 27, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants