Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#19075 - Sort the combobox by native language name #19078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anujeshify
Copy link

Description

This pull request addresses issue #19075.
The language combobox was challenging to read due to the ordering of languages. To enhance usability, I have restructured the order of languages to align with their English names. This change ensures that languages are sorted more intuitively, making them easier to locate and facilitating a coherent viewing experience.

Changes Made
In src/Language.php, the following modifications were made:

public function getName(): string {
    if ($this->native !== '') {
        return $this->name . ' - ' . $this->native;
    }

    return $this->name;
}

Fixes
This pull request fixes the readability issue in the language combobox.

Signed-off-by: Anujesh Bansal anujeshbansaltoo@gmail.com

@phpmyadmin-bot
Copy link
Contributor

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@M393
Copy link
Contributor

M393 commented Mar 22, 2024

The two suggested alternatives from #19075 were

  1. Sort by the native language (my preferation)
  2. Put the English language name first

The title of this pull request is from alternative 1, but it actually implements alternative 2.

Looks like you selected the wrong branch as the merge target, should be master instead of QA_5_2

@williamdes williamdes changed the base branch from QA_5_2 to master April 27, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants