Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive table edit-box in rtl mode #19089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rezsk
Copy link

@rezsk rezsk commented Mar 31, 2024

Description

Fixes positioning issue of responsive table's edit-box on RTL.

Fixes #18472

Signed-off-by: Reza Askari <git@rzsk.net>
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.23%. Comparing base (d61a059) to head (b2d9fce).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #19089      +/-   ##
============================================
+ Coverage     59.18%   59.23%   +0.04%     
  Complexity    15908    15908              
============================================
  Files           671      671              
  Lines         61293    61293              
============================================
+ Hits          36277    36305      +28     
+ Misses        25016    24988      -28     
Flag Coverage Δ
dbase-extension 59.18% <ø> (ø)
unit-8.1-ubuntu-latest 59.15% <ø> (+0.04%) ⬆️
unit-8.2-ubuntu-latest 59.16% <ø> (+0.04%) ⬆️
unit-8.3-ubuntu-latest 59.11% <ø> (+0.03%) ⬆️
unit-8.4-ubuntu-latest 59.11% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks okay, @MauricioFauth what do you think ?
Also: this should go to QA

@rezsk rezsk changed the base branch from master to QA_5_2 May 8, 2024 16:31
@phpmyadmin-bot
Copy link
Contributor

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@rezsk rezsk changed the base branch from QA_5_2 to master May 8, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Edit Field position on RTL
3 participants