Fix column sorting with limit subquery #19146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## QA_5_2 #19146 +/- ##
============================================
+ Coverage 48.64% 49.98% +1.34%
+ Complexity 17015 16675 -340
============================================
Files 607 607
Lines 72326 69296 -3030
============================================
- Hits 35183 34638 -545
+ Misses 37143 34658 -2485
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MoonE
force-pushed
the
limit-subquery-order
branch
from
b0014b1
to
1d2c808
Compare
The used regex found the subquery limit and added the order clause before that. Better to use Query::replaceClause here. Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
MoonE
force-pushed
the
limit-subquery-order
branch
from
1d2c808
to
901ea26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16817