Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed checks for lzf when headers are inside include/liblzf (ubuntu 20.04) #1778

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iliaal
Copy link
Contributor

@iliaal iliaal commented Jun 4, 2020

Fixed checks for lzf when headers are inside include/liblzf (ubuntu 20.04)

In some distributions lzf.h is not inside include/ but instead in include/libzlf this tweak adds extra checks for that allowing lzf support to be enabled.

Updated PR to be based on develop branch

@remicollet
Copy link
Collaborator

IMHO, should be better to rely on pkg-config output, especially as this is now the default way for lot of libraries (7.4+)

@remicollet
Copy link
Collaborator

@iliaal can you check if PR #1779 works for you ?

@iliaal
Copy link
Contributor Author

iliaal commented Jun 4, 2020

IMHO, should be better to rely on pkg-config output, especially as this is now the default way for lot of libraries (7.4+)

The issue is that pkg-config may not be installed. For example ubuntu 20.04 or 18.04 by default doesn't seem to include it, even with dev tools installed

@remicollet
Copy link
Collaborator

pkg-config is a must have now, since 7.4, heavily used but lot of extensions.

BTW, I didn't mean that this change is bad, both PR can be merged, only that pkg-config is the cleanest way to find build options, rather than having distro specific checks.

@iliaal
Copy link
Contributor Author

iliaal commented Jun 5, 2020

pkg-config is a must have now, since 7.4, heavily used but lot of extensions.

BTW, I didn't mean that this change is bad, both PR can be merged, only that pkg-config is the cleanest way to find build options, rather than having distro specific checks.

That makes sense, if pkg-config available it clearly is a cleaner approach, if it doesn't then the older approach with patch I think is a valid solution

@iliaal
Copy link
Contributor Author

iliaal commented Jun 18, 2020

@michael-grunder What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants