Skip to content

Commit

Permalink
composer: add System to psr-0 autoload section
Browse files Browse the repository at this point in the history
  • Loading branch information
terrafrost committed Feb 28, 2014
1 parent 76c9692 commit 0ea31d9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
"Crypt": "phpseclib/",
"File": "phpseclib/",
"Math": "phpseclib/",
"Net": "phpseclib/"
"Net": "phpseclib/",
"System": "phpseclib/"
},
"files": [
"phpseclib/Crypt/Random.php"
Expand Down

6 comments on commit 0ea31d9

@bantu
Copy link
Member

@bantu bantu commented on 0ea31d9 Feb 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah. Kind of sucks that we have to list all of them seperately.

@GrahamCampbell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you just re-release 0.3.6 to include this?

@bantu
Copy link
Member

@bantu bantu commented on 0ea31d9 Mar 1, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamCampbell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been better to push a 0.3.7.

@terrafrost
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem in doing it?

Making a new 0.3.7 release doesn't really have a lot of appeal to me. Am I supposed to repackage PEAR and update the docs and all that jazz when there aren't even any real code changes? Do I go to freshmeat.org and say "new version - no changes - i just like changing version numbers for fun!". Or maybe I have a brand spanking new 0.3.7 on composer and PEAR and all the downloads are still 0.3.6? That's gonna be great for confusion.

At best I'm thinking maybe a new 0.3.6a tag can be made. That tag can be unique to composer and 0.3.6 can be kept everywhere else. I guess. Assuming that this is really a problem? And if it is a problem... could someone perchance explain why?

Do keep in mind I'm not the biggest composer expect in the universe. If I was this wouldn't have been an issue in the first place lol.

@GrahamCampbell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a retag of 0.3.6 rather than a 0.3.6a tag. I hate that notation.

Please sign in to comment.