Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for AES IGE #1095

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Added support for AES IGE #1095

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
12dc23d
Added support for AES IGE
danog Feb 10, 2017
e2f91cc
Use protected iv_size attribute to store required IV size
danog Feb 11, 2017
200c2a9
Merge branch 'master' of https://github.com/phpseclib/phpseclib
danog May 11, 2017
6d714a6
Merge
danog Oct 5, 2017
52c068a
Fixes
danog Oct 5, 2017
1a730d1
Add missing primes static attribute
danog Oct 5, 2017
273ad17
Bugfix
danog Oct 6, 2017
4e367c9
Fixes for phar archives
danog Feb 20, 2018
0d9dc46
Merge main origin
danog Feb 20, 2018
a74a5f7
Fix syntax error
danog Feb 20, 2018
27370df
Fixes for eval engine
danog Feb 20, 2018
3097d29
Merge remote
danog Jun 14, 2019
0aff25e
Fix bad merge
danog Jun 14, 2019
c85ddd3
Use length multiplier
danog Jun 14, 2019
2dc68c8
Rewrite IGE
danog Jun 15, 2019
c62fc0c
Enable openssl w/ IGE
danog Jun 16, 2019
2dc143a
Performance improvements
danog Jun 17, 2019
5e7d391
Fixes to tests
danog Jun 17, 2019
f715b29
Merge
danog Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion phpseclib/Math/BigInteger/Engines/PHP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ abstract class PHP extends Engine
* @access protected
*/
const ENGINE_DIR = 'PHP';

/**
* Primes > 2 and < 1000
*
* @var array
*/
protected static $primes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$primes is defined in PHP32.php and PHP64.php. PHP.php is abstract so it can't be instantiated anyway.

The reason I defined $primes in PHP32.php and PHP64.php was so that you wouldn't run into problems if you tried to instantiate both of them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind - I see you undid that in a newer commit - that you changed, later, self::$primes to static::$primes. I'd say that'd be a good PR on it's own. Maybe try adding a unit test too.


/**
* Default constructor
Expand Down Expand Up @@ -1326,4 +1333,4 @@ protected function powHelper(PHP $n)

return $temp;
}
}
}