SSH2: Better support for multiple interactive channels & expose shell functions: 3.0 Backport #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rposky
changed the title
…ractive channel open statuses. Removed in_request_pty_exec and in_subsystem flags, and removed uses of MASK_SHELL in bitmap, replacing with open channel status queries. Adding channel argument to read, write, and reset allowing callers to select among multiple open interactive channels. Adding interactive channel identifier interface as sanctioned path for users to obtain channels ids instead of using channel constants. Deprecating get_interactive_channel helper and documenting its "legacy" behavior in read, write, and reset doc blocks. Removing disconnect on timeout in channel close for lack of clarity around timeout origin. Check for open channel prior to closing in stopSubsystem and reset.
|
I'm vacationing in California now but I'll try to take a look at this in the next few days! (I'm gonna be doing https://www.wired.com/story/do-before-you-die-climb-a-redwood/ in a few days!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to pull request #1888 for details.